Merged
Conversation
pawanjay176
approved these changes
Apr 3, 2025
Member
pawanjay176
left a comment
pawanjay176
left a comment
There was a problem hiding this comment.
LGTM. The div_ceil use seems equivalent with the previous code
Member
|
We should maybe target this at release-v7.0.0 and then back port to unstable, and make any additional changes necessary for unstable in a different PR? |
Member
|
Could we just cherry-pick into release branch afterwards, or would it cause conflicts? (coz we can insta merge now given green CI and unblock CI on unstable) |
Member
|
There'll be some amount of duplication unless we go release 7.0 to unstable, because if we cherry-pick it will get merged back. But doesn't matter too much. |
Merged
Member
Author
|
Let's go with v7.0.0 -> unstable, I think unstable can survive until the back merge |
macladson
force-pushed
the
rust-lints-1.86.0
branch
from
a5fa4f2 to
7342113
Compare
michaelsproul
added
ready-for-merge
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at 82d1674 |
Member
Member
|
@mergify refresh |
✅ Pull request refreshed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implement lints for the new Rust compiler version 1.86.0.
Additional Info
There's a couple of spicy math/iteration changes which could do with a double check